Update sawp dependencies to 0.13.1 due to SPDX license compatibility. #12328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the version of sawp used to one that is corrected upstream to be compatible with SPDX license scanners.
victorjulien
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Thanks for looking into this. We need a couple of changes:
- we need to also update Cargo.lock.in
- since
masteralso uses the oldersawp, we need to address it there first, and then consider a backport
In general, we are conservative in main-7.0.x with updating anything other than a patch version, so we'll also have to review what risks we'd introduce by bumping the minor version here.
|
Sounds good - will be making the changes shortly! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the version of sawp used to one that is corrected upstream to be compatible with SPDX license scanners.
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
Describe changes: